Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-16831] TS Strict crypto function service #12737

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

MGibson1
Copy link
Member

@MGibson1 MGibson1 commented Jan 7, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-16831

📔 Objective

This PR makes crypto function services TS-strict compliant and improves the type safety of AES decryption

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@MGibson1 MGibson1 requested a review from a team as a code owner January 7, 2025 23:37
Copy link
Contributor

github-actions bot commented Jan 7, 2025

Logo
Checkmarx One – Scan Summary & Detailsc0b98f6f-3e01-45b6-afaa-f16d616a00e5

No New Or Fixed Issues Found

Copy link

codecov bot commented Jan 7, 2025

Codecov Report

Attention: Patch coverage is 85.71429% with 3 lines in your changes missing coverage. Please review.

Project coverage is 34.19%. Comparing base (91d6963) to head (a8a784c).
Report is 9 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...c/platform/services/web-crypto-function.service.ts 80.00% 1 Missing and 1 partial ⚠️
...ces/cryptography/encrypt.service.implementation.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12737      +/-   ##
==========================================
- Coverage   34.29%   34.19%   -0.10%     
==========================================
  Files        2900     2936      +36     
  Lines       89687    90155     +468     
  Branches    16846    16930      +84     
==========================================
+ Hits        30760    30831      +71     
- Misses      56508    56885     +377     
- Partials     2419     2439      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MGibson1 MGibson1 changed the title [PM-16831] TS Strict crypto function servive [PM-16831] TS Strict crypto function service Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants