Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-16838] Forbid imports containing /src/ #12744

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

Hinton
Copy link
Member

@Hinton Hinton commented Jan 8, 2025

๐ŸŽŸ๏ธ Tracking

https://bitwarden.atlassian.net/browse/PM-16838

๐Ÿ“” Objective

Forbids bad imports containing /src/. Should be merged once all bad imports have been fixed.

๐Ÿ“ธ Screenshots

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests โœ…

Project coverage is 34.16%. Comparing base (3949aae) to head (4500bed).

โœ… All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12744   +/-   ##
=======================================
  Coverage   34.15%   34.16%           
=======================================
  Files        2936     2936           
  Lines       90192    90192           
  Branches    16928    16928           
=======================================
+ Hits        30807    30814    +7     
+ Misses      56938    56931    -7     
  Partials     2447     2447           

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

@Hinton Hinton changed the title Forbid imports containing /src/ [PM-16838] Forbid imports containing /src/ Jan 8, 2025
Copy link
Contributor

github-actions bot commented Jan 8, 2025

Logo
Checkmarx One โ€“ Scan Summary & Details โ€“ f523a3dd-f968-406a-a8f9-4ce59264d7f3

Fixed Issues

Severity Issue Source File / Package
MEDIUM Client_Privacy_Violation /apps/browser/src/background/runtime.background.ts: 374

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant