[PM-16699] Add decrypt trace for decrypt failures #12749
Conversation
…o km/improve-logging
quexten
requested review from
dani-garcia,
audreyality,
shane-melton and
rr-bw
quexten
changed the title
quexten
changed the title
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #12749 +/- ##
==========================================
+ Coverage 34.13% 34.15% +0.01%
==========================================
Files 2937 2937
Lines 90332 90350 +18
Branches 16958 16970 +12
==========================================
+ Hits 30839 30863 +24
+ Misses 57038 57031 -7
- Partials 2455 2456 +1 ☔ View full report in Codecov by Sentry. |
|
No New Or Fixed Issues Found |
| 1, | ||
| null, | ||
| "cryptoKey", | ||
| "Property: name; ObjectContext: No Domain Context", |
There was a problem hiding this comment.
🤔 Seems like this should identify that it's coming from a send. That way it'd be distinguished from the name on other domain objects.
|
Hey @quexten, auth changes look good, but I see two failing tests. |
|
@rr-bw seems to just have been intermittent failure from some timeout. Updating the branch fixed it. |
| @@ -32,6 +32,7 @@ export class Password extends Domain { | |||
| }, | |||
| orgId, | |||
| encKey, | |||
| "DomainType: PasswordHistory", | |||
There was a problem hiding this comment.
Is there a reason not to have cipher context for the password history?
🎟️ Tracking
#12681
📔 Objective
Same PR as #12681 but with decryption logic changes removed, so that it can be included in
rcwithout overwhelming QA.The other PR will be merged later, to improve the decrypt logic.
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes