[PM-16243] Allow users to collapse extension sections #12756
+266
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixed Issues
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #12756 +/- ##
==========================================
- Coverage 34.15% 34.12% -0.03%
==========================================
Files 2937 2938 +1
Lines 90353 90392 +39
Branches 16967 16971 +4
==========================================
- Hits 30856 30847 -9
- Misses 57042 57090 +48
Partials 2455 2455 ☔ View full report in Codecov by Sentry. |
danielleflinn
approved these changes
Jan 9, 2025
There was a problem hiding this comment.
Reviewed the chrome build locally:
✅ Favorites and all items have collapsable indicator when hovered
✅ Focus indicator visually looks as expected
✅ Click target is WCAG AA minimum 24px
✅ Screen reader properly announces if the section is expanded or collapsed
✅ Closed sections auto expand when a search term or filter is applied
✅ Closed/Open state persists when extension is closed, user moves to a different tab and returns, or searches and clears the search
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-16243
📔 Objective
This PR adds the ability to collapse the "favorites" and "all items" sections of the browser extension vault. The collapse state is stored locally so that the user's preference is remembered when the extension is opened again on the same device.
When searching or filtering, the collapsed sections are automatically expanded to display search results. The user's preference is remembered when exiting a search/filter view. If a user changes the collapse state of a section while searching or filtering, that preference will be carried to the main vault page and remembered.
📸 Screenshots
Functionality of collapsible sections:
Screen.Recording.2025-01-09.at.9.43.06.AM.mov
Autofill section is not collapsible:
Screen.Recording.2025-01-09.at.9.45.27.AM.mov
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes