Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CL-556] prevent importing DS in common lib #12762

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

willmartian
Copy link
Contributor

@willmartian willmartian commented Jan 8, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/CL-556

📔 Objective

Prevent importing libs/components from libs/common/**/*

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@willmartian willmartian marked this pull request as draft January 8, 2025 20:35
Copy link
Contributor

github-actions bot commented Jan 8, 2025

Logo
Checkmarx One – Scan Summary & Details5a5fc625-0a51-4d25-bbca-875e13fd847b

No New Or Fixed Issues Found

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 34.13%. Comparing base (16a0176) to head (6fc2daf).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12762      +/-   ##
==========================================
- Coverage   34.14%   34.13%   -0.01%     
==========================================
  Files        2937     2937              
  Lines       90337    90334       -3     
  Branches    16961    16961              
==========================================
- Hits        30846    30839       -7     
- Misses      57036    57040       +4     
  Partials     2455     2455              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@willmartian willmartian changed the title prevent importing DS in common lib [CL-556] prevent importing DS in common lib Jan 8, 2025
@willmartian willmartian requested a review from Hinton January 8, 2025 21:30
@willmartian willmartian marked this pull request as ready for review January 8, 2025 21:30
@willmartian willmartian requested a review from a team as a code owner January 8, 2025 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant