Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update dependencies in premium-badge story #12766

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

jaasen-livefront
Copy link
Collaborator

@jaasen-livefront jaasen-livefront commented Jan 9, 2025

🎟️ Tracking

📔 Objective

This PR adds/modifies some dependencies to the premium badge story that were causing the rendering to fail.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@jaasen-livefront jaasen-livefront requested a review from a team as a code owner January 9, 2025 01:13
@jaasen-livefront jaasen-livefront changed the title add missing provider in premium-badge story add missing dependencies in premium-badge story Jan 9, 2025
@jaasen-livefront jaasen-livefront changed the title add missing dependencies in premium-badge story update dependencies in premium-badge story Jan 9, 2025
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 34.15%. Comparing base (bb61b3d) to head (8df0df9).
Report is 18 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
.../src/app/vault/components/premium-badge.stories.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12766   +/-   ##
=======================================
  Coverage   34.14%   34.15%           
=======================================
  Files        2937     2937           
  Lines       90340    90343    +3     
  Branches    16963    16964    +1     
=======================================
+ Hits        30846    30853    +7     
+ Misses      57039    57035    -4     
  Partials     2455     2455           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Jan 9, 2025

Logo
Checkmarx One – Scan Summary & Details8f791045-323d-4224-912a-e8a526a87239

No New Or Fixed Issues Found

@jaasen-livefront jaasen-livefront removed the request for review from shane-melton January 9, 2025 17:27
@jaasen-livefront jaasen-livefront merged commit 8fe1802 into main Jan 9, 2025
41 of 42 checks passed
@jaasen-livefront jaasen-livefront deleted the bugfix/fix-missing-dep-premium-badge branch January 9, 2025 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants