Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-7349] add snap description #8672

Merged
merged 1 commit into from
Apr 10, 2024
Merged

Conversation

jlf0dev
Copy link
Member

@jlf0dev jlf0dev commented Apr 10, 2024

Type of change

- [ ] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [x] Other

Objective

Adds instructions to the snap description to enable required permissions.

Related: #8651

Code changes

  • file.ext: Description of what was changed and why

Screenshots

Before you submit

  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team
  • Ensure that all UI additions follow WCAG AA requirements

@github-actions github-actions bot added the needs-qa Marks a PR as requiring QA approval label Apr 10, 2024
Copy link

codecov bot commented Apr 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.21%. Comparing base (9d10825) to head (791e20f).
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8672      +/-   ##
==========================================
- Coverage   27.22%   27.21%   -0.02%     
==========================================
  Files        2337     2338       +1     
  Lines       68114    68229     +115     
  Branches    12733    12742       +9     
==========================================
+ Hits        18543    18567      +24     
- Misses      48177    48267      +90     
- Partials     1394     1395       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jlf0dev jlf0dev merged commit 94bfdf2 into main Apr 10, 2024
34 checks passed
@jlf0dev jlf0dev deleted the auth/pm-7349/add-snap-description branch April 10, 2024 17:03
@jlf0dev jlf0dev removed the needs-qa Marks a PR as requiring QA approval label Apr 10, 2024
jlf0dev added a commit that referenced this pull request Apr 10, 2024
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details01523106-566d-4f90-8b7e-b7f8928c0c99

No New Or Fixed Issues Found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants