Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auth - PM-7392 & PM-7436 - Token Service - Desktop - Add disk fallback for secure storage failures #8913

Merged
merged 106 commits into from
Jun 3, 2024

PM-7392 - address PR feedback.

895c825
Select commit
Loading
Failed to load commit list.
Merged

Auth - PM-7392 & PM-7436 - Token Service - Desktop - Add disk fallback for secure storage failures #8913

PM-7392 - address PR feedback.
895c825
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jun 3, 2024 in 0s

28.08% (-0.10%) compared to f3e780a

View this Pull Request on Codecov

28.08% (-0.10%) compared to f3e780a

Details

Codecov Report

Attention: Patch coverage is 45.08197% with 67 lines in your changes are missing coverage. Please review.

Project coverage is 28.08%. Comparing base (f3e780a) to head (895c825).
Report is 17 commits behind head on main.

Files Patch % Lines
apps/desktop/src/app/app.component.ts 0.00% 22 Missing ⚠️
apps/web/src/app/app.component.ts 0.00% 10 Missing ⚠️
libs/common/src/services/api.service.ts 0.00% 8 Missing ⚠️
apps/browser/src/popup/app.component.ts 0.00% 7 Missing ⚠️
apps/browser/src/background/main.background.ts 0.00% 5 Missing ⚠️
libs/angular/src/services/jslib-services.module.ts 0.00% 3 Missing ⚠️
...ibs/common/src/vault/services/sync/sync.service.ts 0.00% 3 Missing ⚠️
libs/common/src/services/notifications.service.ts 0.00% 2 Missing ⚠️
apps/cli/src/service-container.ts 66.66% 1 Missing ⚠️
apps/desktop/src/main.ts 0.00% 1 Missing ⚠️
... and 5 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8913      +/-   ##
==========================================
- Coverage   28.18%   28.08%   -0.10%     
==========================================
  Files        2397     2422      +25     
  Lines       70642    71347     +705     
  Branches    13203    13321     +118     
==========================================
+ Hits        19910    20038     +128     
- Misses      49172    49738     +566     
- Partials     1560     1571      +11

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov