Fix workflow linter detected issues on the workflows

bitwarden · Jan 23, 2025 · 46a6981 · 46a6981
1 parent 225e6cf
commit 46a6981
Show file tree

Hide file tree

Showing 14 changed files with 31 additions and 22 deletions.
diff --git a/.github/workflows/build-cli.yml b/.github/workflows/build-cli.yml
@@ -40,7 +40,7 @@ jobs:
 
   build-windows:
     name: Building CLI for - ${{ matrix.settings.os }} - ${{ matrix.settings.target }}
-    runs-on: ${{ matrix.settings.os || 'ubuntu-latest' }}
+    runs-on: ${{ matrix.settings.os || 'ubuntu-24.04' }}
     needs: setup
     env:
       _PACKAGE_VERSION: ${{ needs.setup.outputs.package_version }}
@@ -128,7 +128,7 @@ jobs:
 
   build-macos:
     name: Building CLI for - ${{ matrix.settings.os }} - ${{ matrix.settings.target }}
-    runs-on: ${{ matrix.settings.os || 'ubuntu-latest' }}
+    runs-on: ${{ matrix.settings.os || 'ubuntu-24.04' }}
     needs: setup
     env:
       _PACKAGE_VERSION: ${{ needs.setup.outputs.package_version }}
@@ -237,7 +237,7 @@ jobs:
 
   build-linux:
     name: Building CLI for - ${{ matrix.settings.os }} - ${{ matrix.settings.target }}
-    runs-on: ${{ matrix.settings.os || 'ubuntu-latest' }}
+    runs-on: ${{ matrix.settings.os || 'ubuntu-24.04' }}
     needs: setup
     env:
       _PACKAGE_VERSION: ${{ needs.setup.outputs.package_version }}

diff --git a/.github/workflows/build-cpp.yml b/.github/workflows/build-cpp.yml
@@ -12,9 +12,11 @@ on:
 
 jobs:
   generate-schemas:
+    name: Generate schemas
     uses: ./.github/workflows/generate_schemas.yml
 
   build_rust:
+    name: Build Rust
     uses: ./.github/workflows/build-rust-cross-platform.yml
 
   build:
@@ -43,13 +45,13 @@ jobs:
       - name: Checkout Repository
         uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
 
-      - name: install dependencies linux
+      - name: Install dependencies linux
         if: runner.os == 'Linux'
         run: |
           sudo apt-get install -y nlohmann-json3-dev
           sudo apt-get install -y libboost-all-dev
 
-      - name: install dependencies macos
+      - name: Install dependencies macos
         if: runner.os == 'macOS'
         run: |
           brew install nlohmann-json

diff --git a/.github/workflows/build-dotnet.yml b/.github/workflows/build-dotnet.yml
@@ -11,9 +11,11 @@ on:
 
 jobs:
   generate_schemas:
+    name: Generate schemas
     uses: ./.github/workflows/generate_schemas.yml
 
   build_rust:
+    name: Build Rust
     uses: ./.github/workflows/build-rust-cross-platform.yml
 
   version:

diff --git a/.github/workflows/build-go.yaml b/.github/workflows/build-go.yaml
@@ -34,7 +34,7 @@ jobs:
           restore-keys: |
             ${{ runner.os }}-go-
 
-      - name: npm ci
+      - name: Run npm ci
         run: npm ci
 
       - name: Generate schemas

diff --git a/.github/workflows/build-java.yml b/.github/workflows/build-java.yml
@@ -9,9 +9,11 @@ on:
 
 jobs:
   generate_schemas:
+    name: Generate schemas
     uses: ./.github/workflows/generate_schemas.yml
 
   build_rust:
+    name: Build Rust
     uses: ./.github/workflows/build-rust-cross-platform.yml
 
   build_java:

diff --git a/.github/workflows/build-napi.yml b/.github/workflows/build-napi.yml
@@ -16,11 +16,12 @@ defaults:
 
 jobs:
   generate_schemas:
+    name: Generate schemas
     uses: ./.github/workflows/generate_schemas.yml
 
   build:
     name: Building @bitwarden/sdk-napi for - ${{ matrix.settings.os }}
-    runs-on: ${{ matrix.settings.os || 'ubuntu-latest' }}
+    runs-on: ${{ matrix.settings.os || 'ubuntu-24.04' }}
     needs: generate_schemas
     strategy:
       fail-fast: false

diff --git a/.github/workflows/build-python-wheels.yml b/.github/workflows/build-python-wheels.yml
@@ -16,6 +16,7 @@ defaults:
 
 jobs:
   generate_schemas:
+    name: Generate schemas
     uses: ./.github/workflows/generate_schemas.yml
 
   setup:
@@ -35,7 +36,7 @@ jobs:
 
   build:
     name: Building Python wheel for - ${{ matrix.settings.os }} - ${{ matrix.settings.target }}
-    runs-on: ${{ matrix.settings.os || 'ubuntu-latest' }}
+    runs-on: ${{ matrix.settings.os || 'ubuntu-24.04' }}
     needs:
       - generate_schemas
       - setup

diff --git a/.github/workflows/build-ruby.yml b/.github/workflows/build-ruby.yml
@@ -79,7 +79,7 @@ jobs:
             cp "temp/${platforms[$i]}/${files[$i]}" "languages/ruby/bitwarden_sdk_secrets/lib/${platforms[$i]}/${files[$i]}"
           done
 
-      - name: bundle install
+      - name: Run bundle install
         run: bundle install
         working-directory: languages/ruby/bitwarden_sdk_secrets
 

diff --git a/.github/workflows/build-rust-crates.yml b/.github/workflows/build-rust-crates.yml
@@ -14,15 +14,15 @@ jobs:
   build:
     name: Building ${{matrix.package}} for - ${{ matrix.os }}
 
-    runs-on: ${{ matrix.os || 'ubuntu-latest' }}
+    runs-on: ${{ matrix.os || 'ubuntu-24.04' }}
 
     strategy:
       fail-fast: false
       matrix:
         os:
-          - macos-latest
-          - ubuntu-latest
-          - windows-latest
+          - macos-13
+          - ubuntu-24.04
+          - windows-2022
 
         package:
           - bitwarden
@@ -46,7 +46,7 @@ jobs:
 
   release-dry-run:
     name: Release dry-run
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-24.04
     if: ${{ github.ref == 'refs/head/main' }}
     needs: build
     steps:

diff --git a/.github/workflows/build-rust-cross-platform.yml b/.github/workflows/build-rust-cross-platform.yml
@@ -48,8 +48,9 @@ jobs:
       - name: Cache cargo registry
         uses: Swatinem/rust-cache@82a92a6e8fbeee089604da2575dc567ae9ddeaab # v2.7.5
 
-      - uses: goto-bus-stop/setup-zig@abea47f85e598557f500fa1fd2ab7464fcb39406 # v2.2.1
+      - name: Install Zig
         if: ${{ contains(matrix.settings.target, 'musl') }}
+        uses: goto-bus-stop/setup-zig@abea47f85e598557f500fa1fd2ab7464fcb39406 # v2.2.1
         with:
           version: 0.12.0
 

diff --git a/.github/workflows/direct-minimal-versions.yml b/.github/workflows/direct-minimal-versions.yml
@@ -16,7 +16,7 @@ defaults:
 jobs:
   direct-minimal-versions:
     name: Check dependencies minimal versions for - ${{ matrix.settings.os }} - ${{ matrix.settings.target }}
-    runs-on: ${{ matrix.settings.os || 'ubuntu-latest' }}
+    runs-on: ${{ matrix.settings.os || 'ubuntu-24.04' }}
     strategy:
       fail-fast: false
       matrix:
@@ -48,5 +48,5 @@ jobs:
         with:
           key: dmv-${{ matrix.settings.target }}-cargo-${{ matrix.settings.os }}
 
-      - name: cargo check direct-minimal-versions
+      - name: Run cargo check direct-minimal-versions
         run: cargo check -Z direct-minimal-versions --all-features
diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml
@@ -13,7 +13,7 @@ jobs:
   style:
     name: Check Style
 
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-24.04
 
     steps:
       - name: Checkout

diff --git a/.github/workflows/minimum-rust-version.yml b/.github/workflows/minimum-rust-version.yml
@@ -16,7 +16,7 @@ defaults:
 jobs:
   msrv:
     name: Check MSRV for - ${{ matrix.settings.os }} - ${{ matrix.settings.target }}
-    runs-on: ${{ matrix.settings.os || 'ubuntu-latest' }}
+    runs-on: ${{ matrix.settings.os || 'ubuntu-24.04' }}
     strategy:
       fail-fast: false
       matrix:
@@ -41,5 +41,5 @@ jobs:
         with:
           key: msrv-${{ matrix.settings.target }}-cargo-${{ matrix.settings.os }}
 
-      - name: cargo check MSRV
+      - name: Run cargo check MSRV
         run: cargo check -p bitwarden --all-features
diff --git a/.github/workflows/rustdoc.yml b/.github/workflows/rustdoc.yml
@@ -16,7 +16,7 @@ concurrency:
 jobs:
   rustdoc:
     name: Rustdoc
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-24.04
 
     steps:
       - name: Checkout
@@ -41,7 +41,7 @@ jobs:
     environment:
       name: github-pages
       url: ${{ steps.deployment.outputs.page_url }}
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-24.04
     needs: rustdoc
     name: Deploy
     steps: