Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-13620]Existing user email linking to create-organization #5315

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cyprain-okeke
Copy link
Contributor

๐ŸŽŸ๏ธ Tracking

https://bitwarden.atlassian.net/browse/PM-13620

๐Ÿ“” Objective

We will update the endpoint behavior so that when the email address for an existing user is submitted, the user is sent an email.

The email content will be the same as the one received by users who do not exist, but the link will be specific to the existing user email and the flow following receipt of the email will differ.

๐Ÿ“ธ Screenshots

Uploading Screen Recording 2025-01-23 at 11.54.43.movโ€ฆ

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

@cyprain-okeke cyprain-okeke requested a review from a team as a code owner January 23, 2025 10:58
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Project coverage is 44.09%. Comparing base (5423e5d) to head (43f6db4).
Report is 16 commits behind head on main.

Files with missing lines Patch % Lines
.../Billing/Models/Mail/TrialInititaionVerifyEmail.cs 0.00% 9 Missing โš ๏ธ
.../Services/Implementations/HandlebarsMailService.cs 0.00% 2 Missing โš ๏ธ
.../SendTrialInitiationEmailForRegistrationCommand.cs 0.00% 1 Missing โš ๏ธ
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5315      +/-   ##
==========================================
+ Coverage   44.02%   44.09%   +0.06%     
==========================================
  Files        1476     1476              
  Lines       68260    68277      +17     
  Branches     6179     6181       +2     
==========================================
+ Hits        30052    30106      +54     
+ Misses      36902    36861      -41     
- Partials     1306     1310       +4     

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

Copy link
Contributor

Logo
Checkmarx One โ€“ Scan Summary & Details โ€“ f61afe2d-4d10-494c-922f-83e4916eb071

Fixed Issues (4)

Great job! The following issues were fixed in this Pull Request

Severity Issue Source File / Package
LOW Heap_Inspection /src/Core/Constants.cs: 168
LOW Heap_Inspection /src/Core/Constants.cs: 167
LOW Use_Of_Hardcoded_Password /src/Core/Constants.cs: 168
LOW Use_Of_Hardcoded_Password /src/Core/Constants.cs: 167

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant