Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-12765] Change error message when subscription canceled and attemp… #5346

Merged
merged 2 commits into from
Feb 6, 2025

Conversation

jonashendrickx
Copy link
Member

…ting to autoscale

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-12765

📔 Objective

Change the error message to match the requirements by 'Product'.

📸 Screenshots

See ticket, for any screenshots or recordings.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@jonashendrickx jonashendrickx requested a review from a team as a code owner January 30, 2025 11:14
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 44.37%. Comparing base (2f2ef20) to head (8df3674).
Report is 36 commits behind head on main.

Files with missing lines Patch % Lines
...le/Services/Implementations/OrganizationService.cs 25.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5346      +/-   ##
==========================================
+ Coverage   44.32%   44.37%   +0.04%     
==========================================
  Files        1483     1487       +4     
  Lines       68419    68595     +176     
  Branches     6173     6179       +6     
==========================================
+ Hits        30326    30438     +112     
- Misses      36784    36838      +54     
- Partials     1309     1319      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Jan 30, 2025

Logo
Checkmarx One – Scan Summary & Detailsfc38a9f3-333b-4cc4-b6ad-fecadad6ebfe

New Issues (3)

Checkmarx found the following issues in this Pull Request

Severity Issue Source File / Package Checkmarx Insight
LOW Log_Forging /src/Api/Auth/Controllers/AccountsController.cs: 713
detailsMethod PostPayment at line 713 of /src/Api/Auth/Controllers/AccountsController.cs gets user input from element model. This element’s value flows th...
Attack Vector
LOW Log_Forging /src/Api/Auth/Controllers/AccountsController.cs: 713
detailsMethod PostPayment at line 713 of /src/Api/Auth/Controllers/AccountsController.cs gets user input from element model. This element’s value flows th...
Attack Vector
LOW Log_Forging /src/Api/Auth/Controllers/AccountsController.cs: 713
detailsMethod PostPayment at line 713 of /src/Api/Auth/Controllers/AccountsController.cs gets user input from element model. This element’s value flows th...
Attack Vector
Fixed Issues (3)

Great job! The following issues were fixed in this Pull Request

Severity Issue Source File / Package
LOW Heap_Inspection /src/Core/AdminConsole/Services/Implementations/RabbitMqEventWriteService.cs: 19
LOW Heap_Inspection /src/Core/AdminConsole/Services/Implementations/RabbitMqEventListenerBase.cs: 29
LOW Heap_Inspection /src/Core/Settings/GlobalSettings.cs: 268

jrmccannon
jrmccannon previously approved these changes Jan 30, 2025
@jonashendrickx jonashendrickx merged commit bc27ec2 into main Feb 6, 2025
53 of 54 checks passed
@jonashendrickx jonashendrickx deleted the PM-12765 branch February 6, 2025 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants