Merge pull request #129 from bizley/no-yii-autoloader

No autoloader required

.gitattributes

@@ -3,5 +3,6 @@
 /phpstan.sh export-ignore
 /phpstan.neon export-ignore
 /phpunit.xml.dist export-ignore
+/phpunit-no-yii-autoload.xml.dist export-ignore
 /infection.json.dist export-ignore
 /yii2-migration.png export-ignore

.github/workflows/build-mysql5.yml

@@ -63,4 +63,4 @@ jobs:
         run: printf "<?php\n\n\$config['mysql']['dsn']='mysql:host=127.0.0.1;port=${{ job.services.mysql.ports['3306'] }};dbname=migration';\n" >> tests/config.local.php;
 
       - name: PHPUnit tests
-        run: vendor/bin/phpunit --exclude-group pgsql,sqlite
+        run: vendor/bin/phpunit --exclude-group pgsql,sqlite,autoloader

.github/workflows/build-mysql8.yml

@@ -63,4 +63,4 @@ jobs:
         run: printf "<?php\n\n\$config['mysql']['dsn']='mysql:host=127.0.0.1;port=${{ job.services.mysql.ports['3306'] }};dbname=migration';\n" >> tests/config.local.php;
 
       - name: PHPUnit tests
-        run: vendor/bin/phpunit --exclude-group pgsql,sqlite
+        run: vendor/bin/phpunit --exclude-group pgsql,sqlite,autoloader

.github/workflows/build-pgsql.yml

@@ -58,4 +58,4 @@ jobs:
         run: printf "<?php\n\n\$config['pgsql']['dsn']='pgsql:host=127.0.0.1;port=${{ job.services.postgres.ports['5432'] }};dbname=postgres';\n" >> tests/config.local.php;
 
       - name: PHPUnit tests
-        run: vendor/bin/phpunit --exclude-group mysql,sqlite
+        run: vendor/bin/phpunit --exclude-group mysql,sqlite,autoloader

.github/workflows/build-sqlite.yml

@@ -44,4 +44,7 @@ jobs:
         run: composer update --prefer-dist --no-interaction --no-progress --optimize-autoloader
 
       - name: PHPUnit tests
-        run: vendor/bin/phpunit --exclude-group mysql,pgsql
+        run: vendor/bin/phpunit --exclude-group mysql,pgsql,autoloader
+
+      - name: PHPUnit autoloader test
+        run: vendor/bin/phpunit --configuration phpunit-no-yii-autoload.xml.dist --group autoloader

phpunit-no-yii-autoload.xml.dist

@@ -0,0 +1,13 @@
+<?xml version="1.0" encoding="utf-8"?>
+<phpunit bootstrap="./tests/bootstrap-no-autoload.php"
+         colors="true"
+         convertErrorsToExceptions="true"
+         convertNoticesToExceptions="true"
+         convertWarningsToExceptions="true"
+         stopOnFailure="false">
+    <testsuites>
+        <testsuite name="Yii 2 Migration Test Suite (No Yii Autoloader)">
+            <directory>./tests</directory>
+        </testsuite>
+    </testsuites>
+</phpunit>

src/Extractor.php

@@ -80,6 +80,10 @@ public function extract(string $migration, array $migrationPaths): void
      */
     private function setDummyMigrationClass(): void
     {
+        // attempt to register Yii's autoloader in case it's not been done already
+        // registering it second time should be skipped anyway
+        spl_autoload_register(['Yii', 'autoload'], true, true);
+
         Yii::$classMap['yii\db\Migration'] = Yii::getAlias('@bizley/migration/dummy/Migration.php');
     }
 

tests/bootstrap-no-autoload.php

@@ -0,0 +1,14 @@
+<?php
+
+error_reporting(-1);
+define('YII_ENABLE_ERROR_HANDLER', false);
+define('YII_DEBUG', true);
+
+$_SERVER['SCRIPT_NAME'] = '/' . __DIR__;
+$_SERVER['SCRIPT_FILENAME'] = __FILE__;
+
+require_once __DIR__ . '/../vendor/autoload.php';
+require_once __DIR__ . '/stubs/Yii.php';
+
+Yii::setAlias('@bizley/migration', __DIR__ . '/../src/');
+Yii::setAlias('@bizley/tests', __DIR__);

tests/functional/NoYiiAutoloaderTest.php

@@ -0,0 +1,38 @@
+<?php
+
+declare(strict_types=1);
+
+namespace bizley\tests\functional;
+
+use bizley\tests\stubs\MigrationControllerStub;
+use Yii;
+use yii\base\Exception;
+use yii\console\ExitCode;
+
+/**
+ * This test should be run separate with phpunit-no-yii-autoload.xml config (bootstrap-no-autoload.php bootstrap)
+ * to make sure no standard Yii autoloader is registered first.
+ * @group autoloader
+ */
+class NoYiiAutoloaderTest extends DbLoaderTestCase
+{
+    /** @var string */
+    public static $schema = 'sqlite';
+
+    /**
+     * @test
+     * @throws Exception
+     */
+    public function shouldProvideOwnYiiAutoloader(): void
+    {
+        $controller = new MigrationControllerStub('migration', Yii::$app);
+        $controller->migrationPath = '@bizley/tests/migrations';
+        MigrationControllerStub::$stdout = '';
+        MigrationControllerStub::$content = '';
+        MigrationControllerStub::$confirmControl = true;
+
+        $this->addBase();
+
+        self::assertEquals(ExitCode::OK, $controller->runAction('update', ['updater_base']));
+    }
+}

tests/stubs/Yii.php

@@ -0,0 +1,11 @@
+<?php
+
+require __DIR__ . '/../../vendor/yiisoft/yii2/BaseYii.php';
+
+class Yii extends \yii\BaseYii
+{
+}
+
+// no autoloader
+Yii::$classMap = require __DIR__ . '/../../vendor/yiisoft/yii2/classes.php';
+Yii::$container = new yii\di\Container();