Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing line search algorithm to pathfinder. #592

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

ColCarroll
Copy link
Contributor

Thank you for opening a PR!

A few important guidelines and requirements before we can merge your PR:

  • pre-commit is installed and configured on your machine, and you ran it before opening the PR;
  • The doc is up-to-date;

Copy link

codecov bot commented Nov 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e0f107f) 99.15% compared to head (f35d5ef) 99.15%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #592      +/-   ##
==========================================
- Coverage   99.15%   99.15%   -0.01%     
==========================================
  Files          50       50              
  Lines        2252     2251       -1     
==========================================
- Hits         2233     2232       -1     
  Misses         19       19              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@junpenglao
Copy link
Member

Thanks! Could you do **lbfgs_kwargs instead?

@junpenglao
Copy link
Member

Unless those kwargs have different default compare to what currently in jaxopt (which IIRC that's why we have them explicit in the first place)

@junpenglao junpenglao merged commit 164a4dd into blackjax-devs:main Nov 28, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants