BUGFIX Fixing .equals possible NPE #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spensonshih
approved these changes
Apr 19, 2024
spensonshih
requested changes
Apr 19, 2024
protoc-jar/src/main/java/io/github/blackrock/protocjar/Protoc.java
Outdated
Show resolved
Hide resolved
spensonshih
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please annotate your PR title to describe what the PR does, then give a brief bulleted description of your PR below. PR titles should begin with [BUGFIX], [FEATURE], [DOCS], [MAINTENANCE], or [CONTRIB]. If a new feature introduces breaking changes for the or configuration files, please also add [BREAKING].
Description
Changing call to equals method at various places to avoid possible NPE
if(input.equals(COMPARE_VALUE)) //hit NullPointerException if input is "null"
Changes Made
Refactored the variable.equals(CONSTANT) to CONSTANT.equals(variable)
Additional Notes
[Add any additional notes or context for the reviewer or future maintainers of this code.]
Thank you for submitting!