Fix Issue #25 #34
Closed
Fix Issue #25 #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 16 commits
June 21, 2024 23:39
As shown in Firefox by examples/*.svg.
Surface examples/*.svg files in git-status.
Bump required Go version to 1.21 for access to functions min() and max().
Refactor for tidiness.
Regression Testing
---
Ran ./pre-push: SVG output of three files changed. Log excerpt:
=== RUN TestExamples
...
examples-regression_test.go:83: Failed to verify contents of 3 .svg files
examples-regression_test.go:130: Writing new SVG and HTML delta files into _examples_new/
examples-regression_test.go:149: complicated.html
examples-regression_test.go:149: regression.html
examples-regression_test.go:149: small-grids.html
...
Visual inspection of .html files in browser shows fix effective in
_examples_new/small-grids.{html,svg}, and no visually apparent change
in the other two sets of results.
|
Mistakenly closed. |
|
Will extend GitHub Action testing, and submit a new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Besides a fix for Issue #25, this extends the current regression tests.
To work through false positives in diffing of SVG file regression test output, generate a visual difference file as well. For ease of implementation, it proved convenient to package this within HTML wrapper files.
This PR is a direct successor of "for-blampe-7.1" -- #33, so if this is applied the other can be closed.