New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Clippy Warnings and Code Quality Improvements #145

Merged

Joinhack merged 1 commit into blessnetwork:main from qvkare:main

Jan 20, 2025

Contributor

qvkare commented Jan 16, 2025 •

edited

Loading

Changes

Replaced buffer operations with more efficient write_all
Optimized string handling (to_string() instead of format!)
Used idiomatic Rust patterns (is_empty(), flatten, cloned)
Improved error handling and type safety
Enhanced enum naming conventions
Removed unnecessary cloning and returns

Impact

No functionality changes
Better performance and memory usage
All tests passing


          fix: clippy warnings

32fd136

dmikey requested review from Joinhack and zees-dev and removed request for Joinhack

January 19, 2025 14:41

Joinhack reviewed

View reviewed changes

crates/blockless-drivers/macro/src/config.rs

Collaborator

Joinhack Jan 20, 2025

I think the name is fine with Field suffix.

crates/blockless-drivers/src/tcp_driver/mod.rs

Collaborator

Joinhack Jan 20, 2025

it's different < 1 with empty

Joinhack merged commit cad54a1 into blessnetwork:main

2 of 3 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet