Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Rails 7.2 #1125

Merged
merged 10 commits into from
Dec 3, 2024
Merged

Conversation

Ithanil
Copy link
Collaborator

@Ithanil Ithanil commented Dec 2, 2024

Updated Rails from 7.1 to 7.2 and made relevant changes accordingly.

Steps:

  1. Address deprecations (Fix deprecations to enable move to Rails 7.2 #1124) [✅]
  2. Upgrade to Rails 7.2 (merge in changes in generated config files, load new defaults, update schema.rb) [✅]

Important notes:

  • I have preserved the configuration of SECRET_KEY_BASE as a plaintext env variable, instead of actually utilizing the "new" (since Rails 5 I think) credentials mechanism, despite the removal of the old Rails secrets mechanism in 7.2. Hence, there is no breaking change here. Credits to https://dev.to/yegorov/how-to-continue-to-use-railsapplicationsecrets-in-rails-72-32c7
  • I have adapted the new Puma thread count default of 3 (from 5)

Links

Notable deprecations:
rails/rails#48134
rails/rails#47675
https://www.stefanwienert.de/blog/2023/10/24/rails-7-1-migrate-from-secrets-yml-to-credentials-enc-yml-short/
https://dev.to/yegorov/how-to-continue-to-use-railsapplicationsecrets-in-rails-72-32c7

Notable changes with 7.2:
https://guides.rubyonrails.org/7_2_release_notes.html
rails/rails#50450

Testing Steps (more testing welcome!)

  • all Rails Tests / RSpecs pass
  • basic API calls (create, join, getMeetings, etc.)
  • getRecordings / recording playback
  • most common rake tasks

Fixed Issues

#1124

@Ithanil Ithanil marked this pull request as ready for review December 3, 2024 10:47
@Ithanil Ithanil changed the title Upgrade to Rails 7.2 [WIP] Upgrade to Rails 7.2 Dec 3, 2024
@farhatahmad farhatahmad merged commit f8680b9 into blindsidenetworks:master Dec 3, 2024
2 checks passed
@Ithanil Ithanil deleted the rails_7.2 branch December 3, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants