Workaround for voice_bridge=99999 (test_voice_bridge) issue #1128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For the solved problem, please refer to the extended description provided here. This PR adds a hard-coded workaround (just rolling the dice again) for the default test_voice_bridge setting of 99999, which will match what is used in 99++% of BBB setups. In the rare case that this setting is changed to a non-default value, this workaround won't break anything (it will just avoid the particular voice bridge number of 99999).
I will open a separate issue to request an improved, configurable version of this workaround for the future (in case the underlying issue in BBB will not be fixed in the foreseeable future).
Fixed issues
#1120