chore: resolve code review feedback

blockchain-lab-um · Jan 12, 2025 · 057fe9e · 057fe9e
1 parent ac5fab1
commit 057fe9e
Show file tree

Hide file tree

Showing 4 changed files with 28 additions and 155 deletions.
diff --git a/packages/dapp/package.json b/packages/dapp/package.json
@@ -55,7 +55,6 @@
     "@vercel/speed-insights": "^1.0.10",
     "class-variance-authority": "^0.7.0",
     "clsx": "^2.1.1",
-    "crypto-js": "^4.2.0",
     "date-fns": "^3.6.0",
     "did-jwt-vc": "^3.2.13",
     "did-resolver": "4.1.0",

diff --git a/packages/dapp/src/components/ShareCredentialModal/index.tsx b/packages/dapp/src/components/ShareCredentialModal/index.tsx
@@ -140,22 +140,22 @@ export const ShareCredentialModal = () => {
         presentationFrame: selectedSdJwtDisclosures,
       });
 
-      if (selectedProofFormat === 'sd-jwt') {
-        if (createPresentationResult.success) {
-          const presentationsArray: string[] = [];
-
-          if ('presentations' in createPresentationResult.data) {
-            createPresentationResult.data.presentations.map(
-              (presentation: { presentation: string }) => {
-                presentationsArray.push(presentation.presentation);
-              }
-            );
-          }
-
-          createPresentationResult = await api.decodeSdJwtPresentation({
-            presentation: presentationsArray,
-          });
+      if (
+        selectedProofFormat === 'sd-jwt' &&
+        createPresentationResult.success
+      ) {
+        let presentationsArray: string[] = [];
+
+        if ('presentations' in createPresentationResult.data) {
+          presentationsArray = createPresentationResult.data.presentations.map(
+            (presentation: { presentation: string }) =>
+              presentation.presentation
+          );
         }
+
+        createPresentationResult = await api.decodeSdJwtPresentation({
+          presentation: presentationsArray,
+        });
       }
     } catch (e: any) {
       console.log(e);

diff --git a/packages/snap/snap.manifest.json b/packages/snap/snap.manifest.json
@@ -26,7 +26,7 @@
       "./files/circuits/credentialAtomicQuerySigV2/circuit_final.zkey",
       "./files/circuits/credentialAtomicQuerySigV2/verification_key.json"
     ],
-    "shasum": "GTYjZxSFal5+bIf44cC89/6SoRp7RBrPZdcrERTt9QA="
+    "shasum": "Z1QJ7cWIiA06KdzQkmK2kbVaZKqVnXAQocT2MBxGU50="
   },
   "initialPermissions": {
     "endowment:ethereum-provider": {},