fix: resolve issue with address display (#528)

blockchain-lab-um · Dec 5, 2023 · 5d6ae05 · 5d6ae05
1 parent 5929343
commit 5d6ae05
Show file tree

Hide file tree

Showing 4 changed files with 50 additions and 30 deletions.
diff --git a/.changeset/eight-masks-mix.md b/.changeset/eight-masks-mix.md
@@ -0,0 +1,5 @@
+---
+'@blockchain-lab-um/dapp': patch
+---
+
+Fixes crash when address is not a string.
diff --git a/packages/dapp/package.json b/packages/dapp/package.json
@@ -36,6 +36,7 @@
     "@vercel/og": "^0.5.20",
     "clsx": "^2.0.0",
     "did-jwt-vc": "^3.2.13",
+    "ethers": "^6.9.0",
     "file-saver": "^2.0.5",
     "googleapis": "^128.0.0",
     "headless-stepper": "^1.9.1",

diff --git a/packages/dapp/src/components/CredentialDisplay/FormatedPanel.tsx b/packages/dapp/src/components/CredentialDisplay/FormatedPanel.tsx
@@ -6,6 +6,7 @@ import {
 import { DocumentDuplicateIcon } from '@heroicons/react/24/outline';
 import { VerifiableCredential } from '@veramo/core';
 import clsx from 'clsx';
+import { isAddress } from 'ethers/address';
 import { useTranslations } from 'next-intl';
 
 import Tooltip from '@/components/Tooltip';
@@ -93,7 +94,9 @@ const CredentialSubject = ({
       <Fragment key={key}>
         {(() => {
           if (key === 'id') return <DIDDisplay did={value} />;
-          if (key === 'address') return <AddressDisplay address={value} />;
+          if (key === 'address' && isAddress(value)) {
+            return <AddressDisplay address={value} />;
+          }
 
           const isObject = !(
             typeof value === 'string' || typeof value === 'number'

diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml