Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve dropdowns #626

Merged
merged 27 commits into from
Apr 24, 2024
Merged

chore: improve dropdowns #626

merged 27 commits into from
Apr 24, 2024

Conversation

SinanovicEdis
Copy link
Contributor

No description provided.

Copy link

changeset-bot bot commented Apr 15, 2024

🦋 Changeset detected

Latest commit: c24dc13

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@blockchain-lab-um/dapp Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

nx-cloud bot commented Apr 15, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit c24dc13. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 4 targets

Sent with 💌 from NxCloud.

@SinanovicEdis SinanovicEdis self-assigned this Apr 15, 2024
Copy link
Member

@pseudobun pseudobun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

  • Fix the padding between those three dropdowns.
  • Replace network name with logo.
  • Use different network logos as discussed internally.

@pseudobun
Copy link
Member

Add changeset and resolve conflicts.

@SinanovicEdis SinanovicEdis requested a review from pseudobun April 22, 2024 07:06
Copy link
Member

@pseudobun pseudobun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Move those dropdowns a little closer:
image
  • Match the Show testnets toggle switch color with the pink one:
image

Copy link

Quality Gate Passed Quality Gate passed for 'blockchain-lab-um_connector'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

Quality Gate Passed Quality Gate passed for 'blockchain-lab-um_docs'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

Copy link

Quality Gate Passed Quality Gate passed for 'blockchain-lab-um_snap'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

Quality Gate Passed Quality Gate passed for 'blockchain-lab-um_did-provider-key'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

Quality Gate Passed Quality Gate passed for 'blockchain-lab-um_datamanager'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@SinanovicEdis SinanovicEdis requested a review from pseudobun April 24, 2024 10:21
@pseudobun pseudobun merged commit 932f6aa into develop Apr 24, 2024
16 checks passed
@pseudobun pseudobun deleted the chore/improve-dropdowns branch April 24, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants