Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: x86-64 Darwin CI; remove left-over FIXMEs #96

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

michalrus
Copy link
Member

@michalrus michalrus commented Nov 29, 2024

Context

Currently on main, the x86_64-darwin run is failing:

Initialized empty Git repository in /private/tmp/nix-build-treefmt-check.drv-0/project/.git/
treefmt v2.1.02024/11/29 13:49:41 INFO using config file: /nix/store/vpf1yg6dcq9765d0qbq94mbq32kipgzw-treefmt.toml
Error: failed to create composite formatter: failed to initialise formatter yamlfmt: formatter command not found in PATH

I was able to reproduce locally, but didn't investigate why. Probably not worth the time, considering we're running 2 other yamlfmts – on x86_64-linux and aarch64-darwin, and they work there.

IMO, let's just disable yamlfmt on x86_64-darwin, and call it a day.

I also removed 2 FIXMEs that I missed in #93 – sorry! 🫣

Important Changes Introduced

none

@michalrus
Copy link
Member Author

@gytis-ivaskevicius, or maybe making the formatter work there would be a task you'd like? I don't know if you have a Darwin machine, though.

@vladimirvolek vladimirvolek merged commit f1f0ed4 into main Nov 29, 2024
5 checks passed
@vladimirvolek vladimirvolek deleted the fix/ci-x86_64-darwin branch November 29, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants