Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: sloads and increments in assembly for gas optimization. #179 #180

Merged
merged 2 commits into from
Jan 16, 2024
Merged

refactor: sloads and increments in assembly for gas optimization. #179 #180

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f6f8078
Fixes: sloads and increments in assembly for gas optimization. #179
blackbeard002 Jan 16, 2024
26a3fad
fixed requested changes: #179
blackbeard002 Jan 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 27 additions & 5 deletions contracts/Swaplace.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,14 +26,16 @@ contract Swaplace is SwapFactory, ISwaplace, IERC165 {
function createSwap(Swap calldata swap) public returns (uint256) {
if (swap.owner != msg.sender) revert InvalidAddress(msg.sender);

uint256 swapId;

unchecked {
assembly {
sstore(_totalSwaps.slot, add(sload(_totalSwaps.slot), 1))

swapId := sload(_totalSwaps.slot)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't change gas usage, we can use the previous way for better legibility

}
}

uint256 swapId = _totalSwaps;

_swaps[swapId] = swap;

emit SwapCreated(swapId);
Expand Down Expand Up @@ -65,7 +67,13 @@ contract Swaplace is SwapFactory, ISwaplace, IERC165 {
assets[i].amountOrId
);
unchecked {
i++;
assembly {
i := mload(0x40)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove line 72

i := add(i, 1)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove line 74

mstore(0x40, i)
}
}
}

Expand All @@ -78,7 +86,13 @@ contract Swaplace is SwapFactory, ISwaplace, IERC165 {
assets[i].amountOrId
);
unchecked {
i++;
assembly {
i := mload(0x40)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove line 91

i := add(i, 1)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove line 93

mstore(0x40, i)
}
}
}

Expand Down Expand Up @@ -126,6 +140,14 @@ contract Swaplace is SwapFactory, ISwaplace, IERC165 {
* @dev Getter function for _totalSwaps.
*/
function totalSwaps() public view returns (uint256) {
return _totalSwaps;
uint256 swapId;

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

totalSwaps is never called on-chain, therefore there is no gas optm., we can keep the original way to preserve legibility

unchecked {
assembly {
swapId := sload(_totalSwaps.slot)
}
}

return swapId;
}
}
Loading