Fix clusterutil print dereference bug #578
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emelialei88
force-pushed
the
drqs-177930877
branch
2 times, most recently
from
1449231 to
a456bee
Compare
emelialei88
force-pushed
the
drqs-177930877
branch
from
a456bee to
d73044c
Compare
emelialei88
changed the title
Signed-off-by: Emelia Lei <[email protected]>
emelialei88
force-pushed
the
drqs-177930877
branch
from
d73044c to
3247a1b
Compare
kaikulimu
requested changes
Jan 26, 2025
|
|
||
| // mqbc_clusterutil.t.cpp -*-C++-*- | ||
| #include <bdlb_print.h> | ||
| #include <bslstl_string.h> |
There was a problem hiding this comment.
Include bsl_string.h instead
| // mqbc_clusterutil.t.cpp -*-C++-*- | ||
| #include <bdlb_print.h> | ||
| #include <bslstl_string.h> | ||
| #include <bslstl_vector.h> |
There was a problem hiding this comment.
Remove unused include. (Also, it would have been bsl_vector.h instead of bslstl_vector.h)
| // limitations under the License. | ||
|
|
||
| // mqbc_clusterutil.t.cpp -*-C++-*- | ||
| #include <bdlb_print.h> |
There was a problem hiding this comment.
Move all of these BDE-related includes under the // BDE section at Line 26
|
|
||
| // validate state | ||
| bmqu::MemOutStream errorDescription; | ||
| int rc = mqbc::ClusterUtil::validateState(errorDescription, |
There was a problem hiding this comment.
Suggested change
| int rc = mqbc::ClusterUtil::validateState(errorDescription, | |
| const int rc = mqbc::ClusterUtil::validateState(errorDescription, |
| // 0. Generate different primary lease Id | ||
| original.setPartitionPrimary(0, 10, 0); | ||
| reference.setPartitionPrimary(0, 9, 0); | ||
|
|
There was a problem hiding this comment.
Could you also add a couple correct queues to make sure we are not generating false alarms?
| keyExtraQueue.begin(), | ||
| mqbu::StorageKey::e_KEY_LENGTH_BINARY); | ||
| out << " partitionId = 2 appIdInfos = [ ] " | ||
| "stateOfAssignment = 0 ]"; |
There was a problem hiding this comment.
ClusterStateQueueInfo::State is defined here. To be informative, we should print NONE instead of 0. The trick is to add the four methods print, toAscii,fromAscii and operator<< similar to how ClusterStateTableState does it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a bug where in
mqbc_clusterutil.cpp, functionClusterUtil::validateState, some shared pointers are not dereferenced correctly.