Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Run sanitizers in docker #580

Merged
merged 42 commits into from
Jan 30, 2025
Merged

CI: Run sanitizers in docker #580

merged 42 commits into from
Jan 30, 2025

Conversation

alexander-e1off
Copy link
Collaborator

Running sanitizers check in docker simplifies CI scripts and allows to run it in both CI and local environment.

@alexander-e1off
Add Dockerfile to build and run sanitizers in docker
5b8e6bc 
Signed-off-by: Aleksandr Ivanov <[email protected]>
@alexander-e1off
Run sanitizers in docker on CI
1f0c39a 
Signed-off-by: Aleksandr Ivanov <[email protected]>
@alexander-e1off
Fix yaml formatting
2064cc3 
Signed-off-by: Aleksandr Ivanov <[email protected]>
@alexander-e1off
Fix yaml formatting
ac3c7ee 
Signed-off-by: Aleksandr Ivanov <[email protected]>
@alexander-e1off
Remove debug
9d15f48 
Signed-off-by: Aleksandr Ivanov <[email protected]>
@alexander-e1off
Try to remove unneeded stuff to save space
96a25c3 
Signed-off-by: Aleksandr Ivanov <[email protected]>
@alexander-e1off
Fix removed dirs
76e1c44 
Signed-off-by: Aleksandr Ivanov <[email protected]>
@alexander-e1off
Save more space by removing unneeded pkgs
48876bb 
Signed-off-by: Aleksandr Ivanov <[email protected]>
@alexander-e1off
Remove sudo
86d0fdc 
Signed-off-by: Aleksandr Ivanov <[email protected]>
@alexander-e1off
debug
4b9f84f 
Signed-off-by: Aleksandr Ivanov <[email protected]>
@alexander-e1off
debug1
65e8109 
Signed-off-by: Aleksandr Ivanov <[email protected]>
@alexander-e1off
debug2
d069c30 
Signed-off-by: Aleksandr Ivanov <[email protected]>
@alexander-e1off
debug2
3f7d05a 
Signed-off-by: Aleksandr Ivanov <[email protected]>
@alexander-e1off
debug3
d7693b3 
Signed-off-by: Aleksandr Ivanov <[email protected]>
@alexander-e1off
debug4
191b804 
Signed-off-by: Aleksandr Ivanov <[email protected]>
@alexander-e1off
debug5
901ae70 
Signed-off-by: Aleksandr Ivanov <[email protected]>
@alexander-e1off
debug6
43e2850 
Signed-off-by: Aleksandr Ivanov <[email protected]>
@alexander-e1off
debug6
adc1aef 
Signed-off-by: Aleksandr Ivanov <[email protected]>
@alexander-e1off
debug7
6b193a3 
Signed-off-by: Aleksandr Ivanov <[email protected]>
@alexander-e1off
debug8
86f8e21 
Signed-off-by: Aleksandr Ivanov <[email protected]>
@alexander-e1off
debug9
9a26172 
Signed-off-by: Aleksandr Ivanov <[email protected]>
@alexander-e1off
debug10
4c5f356 
Signed-off-by: Aleksandr Ivanov <[email protected]>
@alexander-e1off
debug11
a1e9a19 
Signed-off-by: Aleksandr Ivanov <[email protected]>
@alexander-e1off
debug12
978613c 
Signed-off-by: Aleksandr Ivanov <[email protected]>
@alexander-e1off
debug13
2691a37 
Signed-off-by: Aleksandr Ivanov <[email protected]>
@alexander-e1off
debug14
150d2ae 
Signed-off-by: Aleksandr Ivanov <[email protected]>
@alexander-e1off
debug15
3ed216d 
Signed-off-by: Aleksandr Ivanov <[email protected]>
@alexander-e1off
debug16
c0be965 
Signed-off-by: Aleksandr Ivanov <[email protected]>
@alexander-e1off
Remove debug
60ae789 
Signed-off-by: Aleksandr Ivanov <[email protected]>
@alexander-e1off
Fix deps
55ab64a 
Signed-off-by: Aleksandr Ivanov <[email protected]>
@alexander-e1off
Remove run layer
339407f 
Signed-off-by: Aleksandr Ivanov <[email protected]>
@alexander-e1off
Add checking of input arg
6d1c32d 
Signed-off-by: Aleksandr Ivanov <[email protected]>
@alexander-e1off
Merge main, fix merge conflicts
95eb4a0 
Signed-off-by: Aleksandr Ivanov <[email protected]>
@alexander-e1off
Remove sanitizers folder from workflows
578a12b 
Signed-off-by: Aleksandr Ivanov <[email protected]>
@alexander-e1off
Fix deps
5c26572 
Signed-off-by: Aleksandr Ivanov <[email protected]>
@alexander-e1off
Cleanup, update readme.md
dcefe43 
Signed-off-by: Aleksandr Ivanov <[email protected]>
@alexander-e1off
Fix comment
f45a233 
Signed-off-by: Aleksandr Ivanov <[email protected]>
@alexander-e1off alexander-e1off requested a review from a team as a code owner January 23, 2025 11:31
678098
678098 requested changes Jan 29, 2025
View reviewed changes
.github/workflows/sanitize.yaml Outdated Show resolved Hide resolved
.github/workflows/sanitize.yaml Outdated Show resolved Hide resolved
docker/build_deps.sh Outdated Show resolved Hide resolved
docker/build_deps.sh Outdated Show resolved Hide resolved
docker/sanitizers/README.md Outdated Show resolved Hide resolved
docker/sanitizers/Dockerfile Outdated Show resolved Hide resolved
@alexander-e1off
Fix review comments
fad5dc1 
Signed-off-by: Aleksandr Ivanov <[email protected]>
@alexander-e1off
Fix typo
7906927 
Signed-off-by: Aleksandr Ivanov <[email protected]>
@alexander-e1off
Remove debug
fafea37 
Signed-off-by: Aleksandr Ivanov <[email protected]>
678098
678098 approved these changes Jan 30, 2025
View reviewed changes
Copy link
Collaborator

@678098 678098 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, let's check how it works

@alexander-e1off alexander-e1off merged commit d9eddf1 into bloomberg:main Jan 30, 2025
26 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@678098 678098 678098 approved these changes

Assignees

@alexander-e1off alexander-e1off

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexander-e1off @678098