Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normalize Windows paths for forward slashes #42

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Normalize Windows paths for forward slashes #42

wants to merge 2 commits into from

Conversation

npyoung
Copy link

@npyoung npyoung commented Sep 24, 2015

Fix to address #26. Essentially using the solution suggested by @javi7.

@npyoung
Copy link
Author

npyoung commented Oct 2, 2015

@chouhanyang, good to merge?

@npyoung
Copy link
Author

npyoung commented Mar 9, 2016

setup.py was failing under windows because it was trying to copy the bash completion stuff into an absolute path meant for Linux. I just added a fix so bash completion stuff is ignored when not on a Posix box. This project is now totally Windows compatible as far as I can tell!

@chouhanyang
Copy link

Hi,
It is not clear to me how your change would work since you only deal with upload? How about download and other commands?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@npyoung @chouhanyang