Skip to content

Commit

Permalink
Adjusting //cookie/http-state tests name0031 and name0032.
Browse files Browse the repository at this point in the history
Chrome and Firefox aligned on treating `"foo;bar"=baz` as a nameless cookie
with a value of `"foo`, and `"foo\"bar;baz"=qux` as a nameless cookie with
a value of `"foo\"bar`. That is, they both stop parsing the name/value pair
when they hit a `;`. This seems aligned with step 1 of
https://tools.ietf.org/html/draft-ietf-httpbis-rfc6265bis-05#section-5.3,
which defines the `name-value-pair` as everything up to but not including
the first `;`.

Adjusting these tests accordingly, as discussed in
httpwg/http-extensions#1136.

Change-Id: I6930f8e18a8c573b21eaea5614e14c3b957ea0bb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128135
Reviewed-by: Lily Chen <[email protected]>
Commit-Queue: Mike West <[email protected]>
Cr-Commit-Position: refs/heads/master@{#755255}
  • Loading branch information
mikewest authored and Commit Bot committed Apr 1, 2020
1 parent c174357 commit 0e97412
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,8 @@ PASS name0027 - name0027
FAIL name0028 - name0028 assert_equals: expected "" but got "a"
PASS name0029 - name0029
PASS name0030 - name0030
FAIL name0031 - name0031 assert_equals: expected "" but got "\"foo"
FAIL name0032 - name0032 assert_equals: expected "" but got "\"foo\\\"bar"
PASS name0031 - name0031
PASS name0032 - name0032
FAIL name0033 - name0033 assert_equals: expected "" but got "aaa"
Harness: the test ran to completion.

Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Cookie: "foo
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Cookie: "foo\"bar

0 comments on commit 0e97412

Please sign in to comment.