add watch to interactions, send feed with interactions #3448
+16
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ] | ||
| }, | ||
| "feedContext": { | ||
| "type": "string", | ||
| "description": "Context on a feed item that was originally supplied by the feed generator on getFeedSkeleton.", | ||
| "maxLength": 2000 | ||
| }, | ||
| "videoWatchMs": { |
There was a problem hiding this comment.
Would it make sense to use a more generic name here ?
For example: interactionDurationMs could also be for interactionSeen. This metric could also be usefull if we add an interaction that describes how long the user spent reading the responses threads.
| @@ -9,14 +9,19 @@ | |||
| "encoding": "application/json", | |||
| "schema": { | |||
| "type": "object", | |||
| "required": ["interactions"], | |||
| "required": ["interactions", "feed"], | |||
There was a problem hiding this comment.
This change is not backwards compatible. not sure if that matters though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.