(Bluesky #1682) add OpenTelemetry tracing to status #1189
Conversation
d-perl
force-pushed
the
bluesky_1682_add_opentelemetry_tracing
branch
6 times, most recently
from
a44955c to
b59688d
Compare
- Adds opentelemetry-api as a dependency
- Registers traces on __init__ of Status objects,
ending when they are marked done
- Registers traces on Status.wait()
d-perl
force-pushed
the
bluesky_1682_add_opentelemetry_tracing
branch
from
b59688d to
77cbea4
Compare
docs/conf.py
Outdated
| @@ -104,7 +104,7 @@ | |||
| # Example configuration for intersphinx: refer to the Python standard library. | |||
| intersphinx_mapping = { | |||
| "python": ("https://docs.python.org/3", None), | |||
| "bluesky": ("https://blueskyproject.io/bluesky/", None), | |||
| "bluesky": ("https://blueskyproject.io/bluesky/main", None), | |||
There was a problem hiding this comment.
Update to get https://blueskyproject.io/bluesky/main/objects.inv.
|
Hi @mrakitin , thanks for your review, sorry it took me so long to get back to you! The trace is indeed applied to |
d-perl
force-pushed
the
bluesky_1682_add_opentelemetry_tracing
branch
from
4236ea1 to
18e9a5d
Compare
d-perl
force-pushed
the
bluesky_1682_add_opentelemetry_tracing
branch
from
bdabfe2 to
b9d74ca
Compare
|
@dperl-dls, are the CI failures expected? |
|
@mrakitin yes, they're failing on master, unrelated to these changes. I can run all the tests locally and they pass, but I don't really know what I could do about the NSLS epics IOC containers. I was hoping this would be fixed by now and I could rebase. |
I think we need to refresh the image https://hub.docker.com/r/nsls2/epics-docker/tags to unblock the tests. |
d-perl
force-pushed
the
bluesky_1682_add_opentelemetry_tracing
branch
4 times, most recently
from
afc5269 to
e1d1f36
Compare
d-perl
force-pushed
the
bluesky_1682_add_opentelemetry_tracing
branch
9 times, most recently
from
977dbdf to
3ad76a1
Compare
d-perl
force-pushed
the
bluesky_1682_add_opentelemetry_tracing
branch
from
3ad76a1 to
b38c062
Compare
To go along with bluesky/bluesky#1724
opentelemetry-apias a dependency__init__ofStatusBaseobjects, ends it when they are marked done, and attaches some metadata to help identify what the status belongs to - this metadata is added for class specific metadata in each subclassStatusBase.wait()