Propagate exceptions in AndStatus and Signal.set to the user #1230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nished The prior is deprecated for some time already, replaced by the former. Signed-off-by: Sofia Donato Ferreira <[email protected]>
This change both removes usage of a deprecate function call, and improves debugging of exceptions in the code. Signed-off-by: Sofia Donato Ferreira <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces some deprecated usages of
_finished(success=...)with their non-deprecated formsset_finished()andset_exception(...).In particular, this enables propagation of some exceptions back to the user, easing some debugging of issues (I hate seeing the
To obtain more specific, helpful errors in the future, update the Device to use set_exception(...) instead of _finished(success=False)message every time something goes wrong haha 😅)Let me know if I missed something!