Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: do not leak the book-keeping float sub-class out of __init__ #1231

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

FIX: do not leak the book-keeping float sub-class out of __init__ #1231

wants to merge 2 commits into from
+12 −4

Conversation

tacaswell
Copy link
Contributor

Not all serializers (e.g. orjson) will fallback to the float behavior.

@tacaswell tacaswell requested a review from mguijarr January 28, 2025 21:41
tacaswell and others added 2 commits January 29, 2025 09:55
@tacaswell
Copy link
Contributor Author

I squashed this all to 2 commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrakitin mrakitin mrakitin approved these changes

@mguijarr mguijarr Awaiting requested review from mguijarr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tacaswell @mrakitin