Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --api-key CLI option #596

Merged
merged 3 commits into from
Nov 16, 2023

Conversation

danielballan
Copy link
Member

Closes #583

e.g.

tiled serve catalog --temp --api-key=secret

Since there is only ever one key, I think a flag plus the existing env var (TILED_SINGLE_USER_API_KEY) is good enough for now. We can add --api-key-file later if we like.

@danielballan
Copy link
Member Author

FYI, unit testing these CLIs is a known issue, #518.

Copy link
Contributor

@padraic-shafer padraic-shafer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spotted one settings update that gets called multiple times in a for-loop. I think it should get moved out of that loop.

The rest looks good.

tiled/server/app.py Outdated Show resolved Hide resolved
Copy link
Contributor

@padraic-shafer padraic-shafer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a helpful addition to the Tiled CLI

@padraic-shafer padraic-shafer merged commit 5df70f8 into bluesky:main Nov 16, 2023
8 checks passed
@danielballan danielballan deleted the add-api-key-option branch November 16, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support single-user API key configuration via CLI arg?
2 participants