-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add architecture documentation #599
Conversation
Wow, I didn't even have to do any work and I get credit? 🤫 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice!
I think that adding subheadings will help draw the reader's eye to key topics. Also they can be linked to in other docs & discussions.
Co-authored-by: Padraic Shafer <[email protected]>
Good edits. I'm stuck on getting any of the
|
For the links to 'H2' tags we might need to set |
I hope we can figure out how to make explicit targets work. I agree with this advice in the docs:
|
I'm trying it locally now. Will report back. |
* https://myst-parser.readthedocs.io/en/latest/syntax/cross-referencing.html#creating-explicit-targets * Hint in sphinx config for adding Myst config options
Ah, I thought that the target was an arbitrary string. I did not realize that the suffix |
I think the '-target' suffix is arbitrary. However, it does remove the |
Oh, you're right. Then I'm not sure what I was doing wrong in some local experiments earlier. Anyway, glad we have a working pattern now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would this be a good place to say (or link to) install client vs server via pip?
Similarly, the end of each sub-section might contain links to the relevant code documentation and further info. E.g.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Built locally; all ref links are working correctly.
Credit to @padraic-shafer for prompting this much needed addition