New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add assertions to sticky id authentication tests #611

Merged

danielballan merged 2 commits into bluesky:main from padraic-shafer:sticky-id-asserts

Nov 28, 2023

Contributor

padraic-shafer commented Nov 28, 2023

test_authentication.py::test_sticky_identity() had some boolean statements that implied an assertion. Those assertions are now explicit.
One of those assertions was failing -- the case labeled "Opt out of the stickiness (set_default=False)". The logic appeared to be reversed from the intention; that has now been corrected.

padraic-shafer added 2 commits

November 28, 2023 05:29


          Add missing asserts in test_sticky_identity

6a22872


          Fix assertion logic when testing: opt out of the stickiness

dbbe55e

padraic-shafer requested a review from danielballan

November 28, 2023 13:43

danielballan approved these changes

View reviewed changes

danielballan merged commit 6b16100 into bluesky:main

8 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet