-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate /node/full/{path}
routes
#612
Deprecate /node/full/{path}
routes
#612
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had imagined that the python client relied on the generic node/full/{path}
route for implementing __getitem__()
. On inspection, it appears that it instead uses the self.links
attribute to find the correct URL path.
Is that correct?
Co-authored-by: Padraic Shafer <[email protected]>
Co-authored-by: Padraic Shafer <[email protected]>
Co-authored-by: Padraic Shafer <[email protected]>
Co-authored-by: Padraic Shafer <[email protected]>
Yes, correct. To elaborate, The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for making these clarifying changes to the HTTP API.
Until #478, the word "node" in tiled has two meanings:
In #478, we introduced the term
container
for (2). Now, every object in tiled in a "node", and every node has a "structure family" which may becontainer
ortable
orarray
or ...The routes
GET /node/full/{path}
andPUT /node/full/{path}
are vestigial, from this legacy. They operate on bothcontainer
andtable
structures, which have similar semantics, in that they can both be filtered by fields/columns.This PR leaves the routes in place, for full backward-compatibility, but adds new routes:
(The omission of
PUT /container/full/{path}
is intentional. Putting container data has never been supported, but is planned.)It updates the Python client to use these new routes.
The goal of this change is:
/table/full/...
for getting a table is more natural than/node/full/...
.