Skip to content

Commit

Permalink
tests: add assertions for main's exit_code
Browse files Browse the repository at this point in the history 
All tests were passing with some `assert 0` to see which tests cover jorgebastida#196,
which should not happen.
  • Loading branch information
@blueyed
blueyed committed May 28, 2018
1 parent 0bc5fe3 commit 266619c
Show file tree
Hide file tree
Showing 2 changed files with 38 additions and 32 deletions.
69 changes: 38 additions & 31 deletions tests/test_it.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -280,7 +280,7 @@ def test_get_streams_from_pattern(self, botoclient):
@patch('sys.stdout', new_callable=StringIO)
def test_main_get(self, mock_stdout, botoclient):
self.set_ABCDE_logs(botoclient)
main("awslogs get AAA DDD --no-color".split())
exit_code = main("awslogs get AAA DDD --no-color".split())
output = mock_stdout.getvalue()
expected = ("AAA DDD Hello 1\n"
"AAA EEE Hello 2\n"
Expand All @@ -290,12 +290,13 @@ def test_main_get(self, mock_stdout, botoclient):
"AAA EEE Hello 6\n"
)
assert output == expected
assert exit_code == 0

@patch('boto3.client')
@patch('sys.stdout', new_callable=StringIO)
def test_main_get_with_color(self, mock_stdout, botoclient):
self.set_ABCDE_logs(botoclient)
main("awslogs get AAA DDD".split())
exit_code = main("awslogs get AAA DDD".split())
output = mock_stdout.getvalue()
expected = ("\x1b[32mAAA\x1b[0m \x1b[36mDDD\x1b[0m Hello 1\n"
"\x1b[32mAAA\x1b[0m \x1b[36mEEE\x1b[0m Hello 2\n"
Expand All @@ -304,27 +305,27 @@ def test_main_get_with_color(self, mock_stdout, botoclient):
"\x1b[32mAAA\x1b[0m \x1b[36mDDD\x1b[0m Hello 5\n"
"\x1b[32mAAA\x1b[0m \x1b[36mEEE\x1b[0m Hello 6\n"
)

assert output == expected
assert exit_code == 0

@patch('boto3.client')
@patch('sys.stdout', new_callable=StringIO)
def test_main_get_query(self, mock_stdout, botoclient):
self.set_json_logs(botoclient)
main("awslogs get AAA DDD --query foo".split())
exit_code = main("awslogs get AAA DDD --query foo".split())
output = mock_stdout.getvalue()
expected = ("\x1b[32mAAA\x1b[0m \x1b[36mDDD\x1b[0m bar\n"
"\x1b[32mAAA\x1b[0m \x1b[36mEEE\x1b[0m {\"bar\": \"baz\"}\n"
"\x1b[32mAAA\x1b[0m \x1b[36mDDD\x1b[0m Hello 3\n"
)

assert output == expected
assert exit_code == 0

@patch('boto3.client')
@patch('sys.stdout', new_callable=StringIO)
def test_get_nogroup(self, mock_stdout, botoclient):
self.set_ABCDE_logs(botoclient)
main("awslogs get --no-group AAA DDD --no-color".split())
exit_code = main("awslogs get --no-group AAA DDD --no-color".split())

self.assertEqual(
mock_stdout.getvalue(),
Expand All @@ -335,12 +336,13 @@ def test_get_nogroup(self, mock_stdout, botoclient):
"DDD Hello 5\n"
"EEE Hello 6\n")
)
assert exit_code == 0

@patch('boto3.client')
@patch('sys.stdout', new_callable=StringIO)
def test_get_nostream(self, mock_stdout, botoclient):
self.set_ABCDE_logs(botoclient)
main("awslogs get --no-stream AAA DDD --no-color".split())
exit_code = main("awslogs get --no-stream AAA DDD --no-color".split())

self.assertEqual(
mock_stdout.getvalue(),
Expand All @@ -351,12 +353,13 @@ def test_get_nostream(self, mock_stdout, botoclient):
"AAA Hello 5\n"
"AAA Hello 6\n")
)
assert exit_code == 0

@patch('boto3.client')
@patch('sys.stdout', new_callable=StringIO)
def test_get_nogroup_nostream(self, mock_stdout, botoclient):
self.set_ABCDE_logs(botoclient)
main("awslogs get --no-group --no-stream AAA DDD --no-color".split())
exit_code = main("awslogs get --no-group --no-stream AAA DDD --no-color".split())

self.assertEqual(
mock_stdout.getvalue(),
Expand All @@ -367,12 +370,13 @@ def test_get_nogroup_nostream(self, mock_stdout, botoclient):
"Hello 5\n"
"Hello 6\n")
)
assert exit_code == 0

@patch('boto3.client')
@patch('sys.stdout', new_callable=StringIO)
def test_get_nogroup_nostream_short_forms(self, mock_stdout, botoclient):
self.set_ABCDE_logs(botoclient)
main("awslogs get -GS AAA DDD --no-color".split())
exit_code = main("awslogs get -GS AAA DDD --no-color".split())

self.assertEqual(
mock_stdout.getvalue(),
Expand All @@ -383,15 +387,15 @@ def test_get_nogroup_nostream_short_forms(self, mock_stdout, botoclient):
"Hello 5\n"
"Hello 6\n")
)
assert exit_code == 0

@patch('boto3.client')
@patch('sys.stdout', new_callable=StringIO)
def test_get_timestamp(self, mock_stdout, botoclient):
self.set_ABCDE_logs(botoclient)
main("awslogs get "
"--timestamp --no-group --no-stream "
"AAA DDD --no-color".split())

exit_code = main("awslogs get "
"--timestamp --no-group --no-stream "
"AAA DDD --no-color".split())
self.assertEqual(
mock_stdout.getvalue(),
("1970-01-01T00:00:00.000Z Hello 1\n"
Expand All @@ -401,15 +405,15 @@ def test_get_timestamp(self, mock_stdout, botoclient):
"1970-01-01T00:00:00.000Z Hello 5\n"
"1970-01-01T00:00:00.000Z Hello 6\n")
)
assert exit_code == 0

@patch('boto3.client')
@patch('sys.stdout', new_callable=StringIO)
def test_get_ingestion_time(self, mock_stdout, botoclient):
self.set_ABCDE_logs(botoclient)
main("awslogs get "
"--ingestion-time --no-group --no-stream "
"AAA DDD --no-color".split())

exit_code = main("awslogs get "
"--ingestion-time --no-group --no-stream "
"AAA DDD --no-color".split())
self.assertEqual(
mock_stdout.getvalue(),
("1970-01-01T00:00:05.000Z Hello 1\n"
Expand All @@ -419,15 +423,15 @@ def test_get_ingestion_time(self, mock_stdout, botoclient):
"1970-01-01T00:00:05.000Z Hello 5\n"
"1970-01-01T00:00:05.009Z Hello 6\n")
)
assert exit_code == 0

@patch('boto3.client')
@patch('sys.stdout', new_callable=StringIO)
def test_get_timestamp_and_ingestion_time(self, mock_stdout, botoclient):
self.set_ABCDE_logs(botoclient)
main("awslogs get "
"--timestamp --ingestion-time --no-group --no-stream "
"AAA DDD --no-color".split())

exit_code = main("awslogs get "
"--timestamp --ingestion-time --no-group --no-stream "
"AAA DDD --no-color".split())
self.assertEqual(
mock_stdout.getvalue(),
("1970-01-01T00:00:00.000Z 1970-01-01T00:00:05.000Z Hello 1\n"
Expand All @@ -437,6 +441,7 @@ def test_get_timestamp_and_ingestion_time(self, mock_stdout, botoclient):
"1970-01-01T00:00:00.000Z 1970-01-01T00:00:05.000Z Hello 5\n"
"1970-01-01T00:00:00.000Z 1970-01-01T00:00:05.009Z Hello 6\n")
)
assert exit_code == 0

@patch('boto3.client')
@patch('sys.stdout', new_callable=StringIO)
Expand Down Expand Up @@ -481,14 +486,14 @@ def paginator(value):

client.get_paginator.side_effect = paginator
client.filter_log_events.side_effect = logs
main("awslogs get AAA DDD --no-color".split())

exit_code = main("awslogs get AAA DDD --no-color".split())
self.assertEqual(
mock_stdout.getvalue(),
("AAA DDD Hello 1\n"
"AAA EEE Hello 2\n"
"AAA DDD Hello 3\n")
)
assert exit_code == 0

@patch('boto3.client')
@patch('sys.stderr', new_callable=StringIO)
Expand Down Expand Up @@ -516,12 +521,12 @@ def paginator(value):

client.get_paginator.side_effect = paginator

code = main("awslogs get AAA foo.*".split())
self.assertEqual(code, 7)
exit_code = main("awslogs get AAA foo.*".split())
self.assertEqual(mock_stderr.getvalue(),
colored("No streams match your pattern 'foo.*' "
"for the given time period.\n",
"red"))
assert exit_code == 7

@patch('boto3.client')
@patch('sys.stdout', new_callable=StringIO)
Expand All @@ -537,13 +542,14 @@ def test_main_groups(self, mock_stdout, botoclient):

client.get_paginator.return_value.paginate.return_value = groups

main("awslogs groups".split())
exit_code = main("awslogs groups".split())
self.assertEqual(
mock_stdout.getvalue(),
("AAA\n"
"BBB\n"
"CCC\n")
)
assert exit_code == 0

@patch('boto3.client')
@patch('sys.stdout', new_callable=StringIO)
Expand Down Expand Up @@ -572,30 +578,31 @@ def paginator(value):

client.get_paginator.side_effect = paginator

main("awslogs streams AAA".split())
exit_code = main("awslogs streams AAA".split())
self.assertEqual(
mock_stdout.getvalue(),
("DDD\n"
"EEE\n")
)
assert exit_code == 0

@patch('sys.stderr', new_callable=StringIO)
def test_unknown_date_error(self, mock_stderr):
code = main("awslogs get AAA BBB -sX".split())
self.assertEqual(code, 3)
exit_code = main("awslogs get AAA BBB -sX".split())
self.assertEqual(mock_stderr.getvalue(),
colored("awslogs doesn't understand 'X' as a date.\n",
"red"))
assert exit_code == 3

@patch('awslogs.bin.AWSLogs')
@patch('sys.stderr', new_callable=StringIO)
def test_unknown_error(self, mock_stderr, mock_awslogs):
mock_awslogs.side_effect = Exception("Error!")
code = main("awslogs get AAA BBB".split())
exit_code = main("awslogs get AAA BBB".split())
output = mock_stderr.getvalue()
self.assertEqual(code, 1)
self.assertTrue("You've found a bug!" in output)
self.assertTrue("Exception: Error!" in output)
assert exit_code == 1

@patch('sys.stderr', new_callable=StringIO)
def test_help(self, mock_stderr):
Expand Down
1 change: 0 additions & 1 deletion tox.ini
View file
Original file line number Diff line number Diff line change
Expand Up @@ -23,5 +23,4 @@ deps = flake8==3.0.4

[flake8]
max-line-length = 120
exclude = tests/*
max-complexity = 28

0 comments on commit 266619c

Please sign in to comment.