feat: support custom blocks to rollback #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
When doing rollback, it will take very long time if the flag |
|
there are some lint issues |
| @@ -12,7 +12,7 @@ import ( | |||
| // Rollback overwrites the current CometBFT state (height n) with the most | |||
| // recent previous state (height n - 1). | |||
| // Note that this function does not affect application state. | |||
| func Rollback(bs BlockStore, ss Store, removeBlock bool) (int64, []byte, error) { | |||
| func Rollback(bs BlockStore, ss Store, removeBlock bool, rollbackBlocks int64) (int64, []byte, error) { | |||
| invalidState, err := ss.Load() | |||
There was a problem hiding this comment.
ss.Load() will load the latest state, which is not the state we are expecting. In the following validators parmsChangeHeight ... are not expected.
There was a problem hiding this comment.
We need heavy changes for this function.
There was a problem hiding this comment.
NextValidators: invalidState.Validators,
Validators: invalidState.LastValidators,
This should be updated.
There was a problem hiding this comment.
fixed to validators loaded from store
|
We need to test validator set change, maybe on dev or qa env. |
forcodedancing
approved these changes
Jan 24, 2024
unclezoro
approved these changes
Jan 25, 2024
forcodedancing
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
support custom blocks to rollback
Changes
Notable changes: