feat: support OPBNB cross-chain #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yutianwu
reviewed
Oct 18, 2023
| var latestBlockHeight uint64 | ||
| if l.isOpCrossChain() { | ||
| // currently Get finalized block is not support by OPBNB yet | ||
| latestBlockHeight, err = l.bscExecutor.GetLatestBlockHeightWithRetry() |
There was a problem hiding this comment.
do we need to add more blocks for finality of opbnb
There was a problem hiding this comment.
This is done is the voteProcessor, num of blocks will be waited before broadcasting vote
There was a problem hiding this comment.
for opbnb, we consider it as one block finality.
anewt95
approved these changes
Nov 7, 2023
yutianwu
approved these changes
Nov 14, 2023
unclezoro
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Modify the current relayer with minimal change to enable crosschain to OPBNB
Rationale
tell us why we need these changes...
Example
add an example CLI or API response...
Changes
Notable changes: