fix review comments

app/upgrade.go

@@ -65,17 +65,17 @@ func (app *App) registerNagquUpgradeHandler() {
 	app.UpgradeKeeper.SetUpgradeInitializer(upgradetypes.Nagqu,
 		func() error {
 			app.Logger().Info("Init Nagqu upgrade")
-			app.setPaymentConsensusV2()
+			app.setPaymentConsensusVersion(2)
 			return nil
 		})
 }
 
-func (app *App) setPaymentConsensusV2() {
+func (app *App) setPaymentConsensusVersion(version uint64) {
 	mm, ok := app.mm.Modules[paymenttypes.ModuleName].(*paymentmodule.AppModule)
 	if !ok {
 		panic("*paymentmodule.AppModule not found")
 	}
-	mm.SetConsensusVersion(2)
+	mm.SetConsensusVersion(version)
 }
 
 func (app *App) registerPampasUpgradeHandler() {
@@ -109,7 +109,7 @@ func (app *App) registerPampasUpgradeHandler() {
 	app.UpgradeKeeper.SetUpgradeInitializer(upgradetypes.Pampas,
 		func() error {
 			app.Logger().Info("Init Pampas upgrade")
-			app.setPaymentConsensusV2()
+			app.setPaymentConsensusVersion(2)
 			// enable chain id for opbnb
 			app.CrossChainKeeper.SetDestOpChainID(sdk.ChainID(app.appConfig.CrossChain.DestOpChainId))
 			return nil
@@ -133,7 +133,7 @@ func (app *App) registerManchurianUpgradeHandler() {
 	app.UpgradeKeeper.SetUpgradeInitializer(upgradetypes.Manchurian,
 		func() error {
 			app.Logger().Info("Init Manchurian upgrade")
-			app.setPaymentConsensusV2()
+			app.setPaymentConsensusVersion(2)
 			return nil
 		})
 }
@@ -159,18 +159,18 @@ func (app *App) registerHulunbeierUpgradeHandler() {
 	app.UpgradeKeeper.SetUpgradeInitializer(upgradetypes.Hulunbeier,
 		func() error {
 			app.Logger().Info("Init Hulunbeier upgrade")
-			app.setPaymentConsensusV2()
-			app.setVirtualGroupConsensusV2()
+			app.setPaymentConsensusVersion(2)
+			app.setVirtualGroupConsensusVersion(2)
 			return nil
 		})
 }
 
-func (app *App) setVirtualGroupConsensusV2() {
+func (app *App) setVirtualGroupConsensusVersion(version uint64) {
 	mm, ok := app.mm.Modules[virtualgrouptypes.ModuleName].(*virtualgroupmodule.AppModule)
 	if !ok {
 		panic("*virtualgroupmodule.AppModule not found")
 	}
-	mm.SetConsensusVersion(2)
+	mm.SetConsensusVersion(version)
 }
 
 func (app *App) registerHulunbeierPatchUpgradeHandler() {
@@ -187,8 +187,8 @@ func (app *App) registerHulunbeierPatchUpgradeHandler() {
 	app.UpgradeKeeper.SetUpgradeInitializer(upgradetypes.HulunbeierPatch,
 		func() error {
 			app.Logger().Info("Init Hulunbeier patch upgrade")
-			app.setPaymentConsensusV2()
-			app.setVirtualGroupConsensusV2()
+			app.setPaymentConsensusVersion(2)
+			app.setVirtualGroupConsensusVersion(2)
 			return nil
 		})
 }