Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enforce validation on SSP when creating GVG #519

Merged
merged 5 commits into from
Nov 9, 2023

Conversation

alexgao001
Copy link
Collaborator

@alexgao001 alexgao001 commented Nov 7, 2023

Description

Enforce validation on SSP count and duplicate when creating a GVG

Rationale

A Global virtual group should have expected number of sp.

Example

add an example CLI or API response...

Changes

Notable changes:

  • add each change in a bullet point here
  • ...

Potential Impacts

  • add potential impacts for other components here
  • ...

@alexgao001 alexgao001 force-pushed the fix-validate-GVG-SSP-cnt branch from 1977eca to 06b6b2e Compare November 7, 2023 08:55
@alexgao001 alexgao001 changed the title fix: enforce validation on SSP cnt when creating GVG fix: enforce validation on SSP when creating GVG Nov 8, 2023
@alexgao001 alexgao001 force-pushed the fix-validate-GVG-SSP-cnt branch from 20c1063 to 61166e2 Compare November 9, 2023 07:40
@unclezoro unclezoro added this pull request to the merge queue Nov 9, 2023
Merged via the queue into bnb-chain:develop with commit ce13fea Nov 9, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants