fix: remove tags field from existed msgs
#543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
merge to master instead of develop branch? |
|
fix the lint check please |
pythonberg1997
force-pushed
the
develop
branch
from
3dc5254 to
24ef629
Compare
pythonberg1997
changed the title
tags to pointer in all msgstags field from existed msgs
unclezoro
previously approved these changes
Dec 20, 2023
unclezoro
approved these changes
Dec 21, 2023
This was referenced Dec 21, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr is to remove
tagsfield from existed msgs and revert other related setting.Rationale
Modify existed msgs will result in forward incompatibility. So we have to revert them.
Changes
Notable changes:
tagsfield from existed msgsPotential Impacts