fix: principal value supports group name #626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix: principal value supports group name comments
Rationale
The user discovered that the current cross-chain process does not support creating a group and binding it to a bucket/object through a multi-message in a single transaction. This is because they believed that the principal value only supports a group ID, not a group name.
However, this is actually supported, but it requires a specific naming convention to be followed. The format should be:
grn:g:ownerAddress:groupName. We will update the corresponding principal value comment to support group names, to prevent any misunderstanding by developers in the future.Example
Go-SDK
BSC Testnet transaction
https://testnet.bscscan.com/tx/0xc983b0ef02796a9e0b6f3a7eb13fc2fbfe22895ba17fbd8a54f7becff8b2d183
Greenfield
Changes
Notable changes:
Potential Impacts
N/A