feat(op-geth): support droppingTxHashes when sendBundle #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
irrun
approved these changes
Dec 18, 2024
welkin22
reviewed
Dec 19, 2024
owen-reorg
reviewed
Dec 19, 2024
owen-reorg
reviewed
Dec 23, 2024
owen-reorg
reviewed
Dec 26, 2024
| } | ||
| wg.Wait() | ||
| bundleGauge.Update(int64(len(p.bundles))) |
There was a problem hiding this comment.
do we need these 2 lines if we early return when len(p.bundles) == 0?
owen-reorg
reviewed
Dec 26, 2024
core/txpool/bundlepool/bundlepool.go
Outdated
| defer wg.Done() | ||
| if (bundle.MaxTimestamp != 0 && newHead.Time > bundle.MaxTimestamp) || | ||
| (bundle.MaxBlockNumber != 0 && newHead.Number.Cmp(new(big.Int).SetUint64(bundle.MaxBlockNumber)) > 0) { | ||
| p.slots -= numSlots(p.bundles[hash]) |
There was a problem hiding this comment.
Is it thread safe to do p.slots -= and delete(p.bundles, hash)?
There was a problem hiding this comment.
The reset function itself is thread safe since we have
p.mu.Lock()
defer p.mu.Unlock()
in the beginning of the function.
However, if you use go func here, it's not.
There was a problem hiding this comment.
Removed go func, just use single thread.
owen-reorg
reviewed
Dec 26, 2024
core/txpool/bundlepool/bundlepool.go
Outdated
| delete(p.bundles, hash) | ||
| } else { | ||
| for _, tx := range bundle.Txs { | ||
| if txSet.Contains(tx.Hash()) && !containsHash(bundle.DroppingTxHashes, tx.Hash()) { |
There was a problem hiding this comment.
I recommend maintain unDroppableTxHashesSet as a cache, we can use it here and in the check of simulation, avoid iterate the slice again and again.
owen-reorg
reviewed
Dec 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support droppingTxHashes when sendBundle.
Rationale
The atomicity of bundle transactions can lead to a malicious attack. The attacker can send a failed transaction, such as a transaction that has already been on the chain, which will make the entire bundle invalid. Therefore, the new field can remove such transactions.
Example
N/A
Changes
Notable changes: