fix: insert error stage to rpc error in OpSealPayload engine api #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnoieh
requested review from
owen-reorg and
andyzhang2023
and removed request for
krish-nr and
welkin22
owen-reorg
previously approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr fix error return of engine_opSealPaylaod api, related fix to op-node is bnb-chain/opbnb#259
Rationale
The error return of original engine_api is chaos and easy lead to bug, the new engine_opSealPayload api followed the original part, and unfortunately triggered bug, which will cause chain stuck if force kill
Example
n/a
Changes
insert error stage to rpc error in OpSealPayload engine api