Workspace Templates: show error when fetching templates from Github #6440
+43
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This shows "some" error in the UI when there are problems fetching from Github. The error message also includes a hint to https://bnd.bndtools.org/instructions/connection-settings.html because sometimes you have a ~/.m2/settings.xml with some credentials which can lead to "Bad Credentials" http errors from the Github API, but before this fix you had no idea what was going on, because the UI was blank and the existance of ~/.m2/settings.xml is easily forgotton Signed-off-by: Christoph Rueger <[email protected]>
|
@peterkir could you have a look and see what the output is in your error case with the incorrect credentials in |
instead of abusing the description field. this seems better suited to display information about an exception. Signed-off-by: Christoph Rueger <[email protected]>
|
Build error seems to be because of a http error e.g. when accessing stuff from https://download.eclipse.org/ they seem to have maintanance https://www.eclipsestatus.io/ I will retry later |
chrisrueger
changed the title
I noticed it does not used in the final display of the ErrorDialog. Signed-off-by: Christoph Rueger <[email protected]>
since the same http errors can happen there too, so the user should notice that with info whats going wrong Signed-off-by: Christoph Rueger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR
This PR is about error handling the following two wizards:
This shows an ErrorDialog the UI when there are problems fetching from Github. The error message also includes a hint to https://bnd.bndtools.org/instructions/connection-settings.html because sometimes you have a ~/.m2/settings.xml with some credentials which can lead to "Bad Credentials" http errors from the Github API, but before this fix you had no idea what was going on, because the UI was blank and the existance of ~/.m2/settings.xml is easily forgotten
The message reads (wording improvements welcome):
Eclipse Error Log tab:
At least now you see that something is wrong and also get some information.
Before this it was completely unknown, since the list of templates just appeared empty.
Last but not least, I added the same ErrorDialog also to the (new) Template Fragment Wizard... which can suffer from the same HTTP connection problems. Now the user sees an error dialog too and knows what's going on