-
-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spilt Tagged<T>
into a utility crate
#3849
base: main
Are you sure you want to change the base?
Conversation
Test262 conformance changes
|
General discussion on utility crates: how do we want to go about handling utilities in general that's going to be best for maintenance in the long term? Should we have one general There's some benefits to taking the
There could be a pretty big negative around the maintenance complexity utility crates may cause and managing separate releases may actually end being a large headache. 😕 Any thoughts? |
Hmmm... What does the rest of the team say? @jedel1043 @raskad @Razican |
From my side, in general, if the crate / code makes sense outside Boa, then we should make it separate, so that others can benefit from it. If not, I would keep it in. For this case, it seems these types could be used outside of Boa, and they have no dependency on the engine, so I would make them separate if it's not too much maintenance burden (and we don't forget to maintain them 😅) |
I'm not sure what we should name the crate because |
I think separating small utility crates to separate repos is arguably worse for us. I would be in favour of having either a |
We can do that and also maintain it as a separate crate on our main repo. That's what the ICU4X folks do with |
As mentioned above, I'd be for the
|
Depends on #3837
This makes
Tagged<T>
be usable inboa_string
andboa_engine
.