Add WPT as optional tests for boa_runtime #4008
Open
+722
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some methods are NOT currently supported (some don' make sense outside of a browser context). They are still implemented but will throw a JavaScript Error. Supported methods should follow the specification perfectly.
To run the tests, you require adding the `wpt-tests` feature and setting the `WPT_ROOT` environment variable on the command line. This is currently depending on a pending rstest PR: la10736/rstest#277 The current set of curated tests are all working.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4008 +/- ##
==========================================
+ Coverage 47.24% 53.79% +6.55%
==========================================
Files 476 486 +10
Lines 46892 48398 +1506
==========================================
+ Hits 22154 26037 +3883
+ Misses 24738 22361 -2377 ☔ View full report in Codecov by Sentry. |
jedel1043
reviewed
Nov 19, 2024
core/runtime/Cargo.toml
Outdated
Comment on lines
35
to
41
| wpt-tests = [] | ||
| # This feature is used to disable compiling the WPT tests in the CI | ||
| # when using `--all-features`. If this feature is enabled, we disable | ||
| # the compilation of the WPT tests (since they will panic). | ||
| # Clippy will be disabled for those methods as well, but they're one | ||
| # line long. | ||
| wpt-tests-do-not-use = [] |
There was a problem hiding this comment.
Hmmm, I think it's slightly weird to have tests be enabled by features instead of by only the test cfg. Can we just have a separate crate in the workspace for wpt tests, just like boa_tester? We could also potentially merge them together in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To run the tests, you require adding the
wpt-testsfeature and setting theWPT_ROOTenvironment variable on the command line.Example:
The current set of curated tests are all working. Some tests have been marked as ignore with a TODO for further work.