Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds inline ngrok auth #42

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

adds inline ngrok auth #42

wants to merge 3 commits into from

Conversation

ChrisC
Copy link

@ChrisC ChrisC commented Jan 9, 2025

No description provided.

@jugglinmike
Copy link
Member

Hey Chris! The version of the script from the main branch works as-is for me. That meant I needed to take extra steps to verify that your change has an effect.

  1. Moved the ~/.config/ngrok directory to ~/.config/ngrok-tmp
  2. Ran the script
  3. Verified failure (error message: "RequestError: connect ECONNREFUSED 127.0.0.1:4040")
  4. Set the NGROK_AUTH_TOKEN environment variable to the authtoken value specified in ~/.config/ngrok-tmp/ngrok.yml
  5. Ran the script
  6. Verified success

Before we land this, though, I would like to understand a little more about what's going wrong. Does your system have that configuration file in place?

For what it's worth, I'm still interested in troubleshooting because I'd like to avoid supporting multiple ways to perform a task. Doing so will tend to complicate both the documentation and future bug diagnosis. It's also possible that this problem is a symptom of environmental differences (e.g. we're running different releases of ngrok), and our solution might look different in that case.

@ChrisC
Copy link
Author

ChrisC commented Jan 14, 2025

Before we land this, though, I would like to understand a little more about what's going wrong. Does your system have that configuration file in place?

@jugglinmike Hmmm, it looks like my config was in the wrong place. It was in the correct place according to ngrok's documentation for MacOS in ~/Library/Application Support/ngrok/ngrok.yml (I think an earlier global install of ngrok may have put there that there for me). I copied my yml to ~/.config/ngrok and verified that the script was able to run.

However, I still would prefer that the code was really explicit about what auth credentials are needed in order for the script to run. Additionally, I don't see how the script will even run in an environment like GH Codespaces, where we don't have access to the full filesystem on the environment running the code, and therefore can't place a config file in the expected location.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants