Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: add "rb" and "encoding" to several with open clause #10

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

bugfix: add "rb" and "encoding" to several with open clause #10

wants to merge 3 commits into from

Conversation

randomseed42
Copy link

  • add "rb" and encoding="utf-8" to several with open() clauses, to avoid encoding errors on specific user environment.
  • use df[“Version"] rather than df.Version to avoid mypy type check error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@randomseed42