Refactor Agency Configuration File Handling and Add Tests #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bonk1t
changed the title
guiparpinelli
approved these changes
Dec 20, 2023
| Returns: | ||
| self: An instance of AgencyConfigFileStorage. | ||
| """ | ||
| self.lock = AgencyConfigLockManager.get_lock(self.agency_id) |
There was a problem hiding this comment.
My original plan for the context manager implementation was to eliminate the need for a separate lock manager class. Instead, the context manager itself would handle the lock. This means that upon entering the context (i.e., during the enter method), it would acquire the lock and then return the opened file. Conversely, upon exiting the context (exit method), it would release the lock and close the file.
| @@ -4,6 +4,7 @@ version = "1.0.0" | |||
| description = "Nalgonda is a FastAPI app to manage swarm agencies" | |||
| authors = [ | |||
| "Nikita Bobrovskiy <[email protected]>", | |||
| "Guilherme Parpinelli <[email protected]>", | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AgencyConfigStorageInterface, an abstract base class defining a standard interface for agency configuration storage.AgencyConfigFileStorage, a concrete class that extendsAgencyConfigStorageInterface. It provides thread-safe file operations for agency-specific configurations using a context manager pattern.AgencyConfigFileStorageby integratingAgencyConfigLockManagerfor managing locks based on agency IDs.AgencyConfigFileStorageto validate functionality such as lock acquisition/release, loading and saving configuration data, and handling default configuration fallbacks when specific agency files are not present.